Docs: Replace deprecated 'compile' with 'implementation' in Gradle snippet#15921
Open
yadavay-amzn wants to merge 1 commit intoapache:mainfrom
Open
Docs: Replace deprecated 'compile' with 'implementation' in Gradle snippet#15921yadavay-amzn wants to merge 1 commit intoapache:mainfrom
yadavay-amzn wants to merge 1 commit intoapache:mainfrom
Conversation
…ippet The Gradle snippet on the Releases page used the 'compile' configuration, which was removed in Gradle 7. Updated to 'implementation' to match current Gradle conventions and Iceberg's own build.gradle. Closes apache#15811
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Gradle snippet on the Releases page uses the
compileconfiguration, which was removed in Gradle 7. Updated toimplementationto match current Gradle conventions.Change:
site/docs/releases.mdline 48:compile→implementationTesting:
Verified
mkdocs buildruns successfully fromsite/directory (the monorepo plugin warning about nightly docs is pre-existing and unrelated)Ran
pymarkdownlnt scan site/docs/releases.md— no lint issues on the changed lineConfirmed Iceberg's own
build.gradleusesimplementation(68 instances) and zero barecompileconfigurations:Searched all docs for any other Gradle
compilereferences — none found:Verified the rendered markdown context is correct — the Gradle snippet now reads:
Closes #15811